Skip to content

Review Checklist

A review checklist is useful only if it catches the real ways this package can drift.

For agentic-proteins, review should ask whether a change shrinks or expands legacy surface area and whether runtime already owns the better place for the behavior.

Review Model

flowchart TB
    review["review proposed bridge change"]
    surface{"legacy surface shrinks or expands?"}
    owner{"runtime should own this instead?"}
    promise{"docs and tests still match the compatibility promise?"}
    approve["ready to approve"]

    review --> surface
    surface --> owner
    owner -->|no| promise
    owner -->|yes| block1["keep reviewing or re-scope"]
    promise -->|yes| approve
    promise -->|no| block2["keep reviewing"]

This checklist should catch the moment a small bridge edit starts behaving like product growth instead of compatibility stewardship.

Review Rules

  • ask whether the change shrinks or expands legacy surface area
  • check whether runtime already owns the better place for the behavior
  • verify that public docs and tests still agree on the compatibility promise

First Proof Check

  • packages/agentic-proteins/tests
  • src/agentic_proteins/interfaces/cli.py and api/app.py
  • src/agentic_proteins/runtime/

Design Pressure

The easy failure is to approve a clean local diff without noticing that the bridge just claimed a broader long-term obligation.