Skip to content

Definition of Done

Done means the package is easier to trust after the change, not just that the diff merged.

For bijux-proteomics-foundation, done is about keeping shared meaning stable enough that every downstream package can still speak the same language after the edit.

Completion Model

flowchart TB
    change["change lands in shared schema or serialization"]
    meaning{"shared meaning still singular?"}
    proof{"migration and serialization proof updated?"}
    downstream{"downstream compatibility path stays explicit?"}
    done["change is done"]

    change --> meaning
    meaning -->|yes| proof
    meaning -->|no| block1["not done"]
    proof -->|yes| downstream
    proof -->|no| block2["not done"]
    downstream -->|yes| done
    downstream -->|no| block3["not done"]

This page should let a reviewer trace the move from edited shared meaning to migration proof and then to downstream safety. If one of those links is missing, the package is only locally green.

Review Rules

  • shared meaning is still clearer after the change than before it
  • migration and serialization proof cover the edited surface
  • downstream packages have an explicit path to remain compatible

First Proof Check

  • packages/bijux-proteomics-foundation/tests
  • src/bijux_proteomics_foundation/schema.py and migrations.py
  • src/bijux_proteomics_foundation/serialization.py

Design Pressure

The easy failure here is to call work done once one package test suite passes, even though the real risk is that every consuming package now inherits a silent meaning split.