Review Checklist¶
Review bijux-gnss-nav as the owner of reusable navigation science:
products, time models, orbit and clock interpretation, correction laws,
estimation, refusal behavior, and integrity evidence. The crate may consume
observations and signal facts, but it should not own receiver scheduling,
repository persistence, or command presentation.
flowchart TB
claim["changed navigation claim"]
family["name the scientific family"]
model["inspect model and product contracts"]
proof["inspect estimator, product, or refusal proof"]
boundary["confirm runtime and repository concerns stay outside"]
claim --> family --> model --> proof --> boundary
Review Gates¶
| changed surface | accept only when | inspect before accepting |
|---|---|---|
| navigation product parser or provider | Product meaning is documented and reusable without repository-file policy. | Format and product contracts and navigation contract guide |
| orbit, clock, time, or model logic | Scientific assumptions and units are explicit enough for downstream callers. | Orbit Contracts, Time And Model Contracts |
| correction law | The correction remains a reusable navigation surface, not receiver tuning. | Correction contracts and precise-correction query proof |
| estimator or positioning behavior | Refusal, downgrade, residual, and integrity outcomes are backed by targeted tests. | Estimation contracts and estimation guide |
| public export | The export represents durable navigation science rather than a caller shortcut. | API surface, public API, and guardrail proof |
Blocking Signs¶
- A solver accepts impossible geometry, missing reference coordinates, or weak residual evidence without a documented refusal or downgrade path.
- A product parser explains file handling but not the scientific meaning of the parsed state.
- A runtime convenience becomes a navigation API even though it only makes one receiver flow easier.
- A reference fixture changes without explaining why the new expectation is scientifically stronger or more representative.
Evidence To Require¶
- Read the navigation test guide, estimation guide, and public API before accepting broad changes.
- Require the narrow test family that matches the changed scientific claim: product, orbit, correction, estimator, integrity, or refusal behavior.
- Update interface docs when public navigation meaning changes.
- Route command rendering, receiver scheduling, and persisted-evidence layout back to their owning crates instead of expanding nav to host them.